Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #47939 #49066 #54963

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Automated cherry pick of #47939 #49066 #54963

merged 2 commits into from
Nov 22, 2017

Conversation

david-mcmahon
Copy link
Contributor

Cherry pick of #47939 #49066 on release-1.7.

#47939: Save docker image tarfiles in _output/release-images/$arch/.
#49066: Always use gcr.io/google_containers for side-loaded Docker

@ixdy @david-mcmahon
Save docker image tarfiles in _output/release-images/$arch/.
519a164 
Additionally, add option KUBE_BUILD_HYPERKUBE to build hyperkube
outside of the release flow.
@ixdy @david-mcmahon
Always use gcr.io/google_containers for side-loaded Docker images
6919b08
@k8s-ci-robot
Copy link
Contributor

@david-mcmahon: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: david-mcmahon
We suggest the following additional approver: jbeda

Assign the PR to them by writing /assign @jbeda in a comment when ready.

Associated issue: 47939

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 2, 2017
@david-mcmahon david-mcmahon added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 2, 2017
@david-mcmahon david-mcmahon assigned ixdy and wojtek-t and unassigned lavalamp and zmerlynn Nov 2, 2017
@david-mcmahon david-mcmahon removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 2, 2017
@david-mcmahon
Copy link
Contributor Author

@wojtek-t What do you think? This will allow you to build staged releases for 1.7. @ixdy Can you confirm I got all the pieces right? There were a couple/few involved PRs for this change.

@david-mcmahon
Copy link
Contributor Author

I should add, I tested this locally and it built/created the image tars.

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 13, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Nov 13, 2017
@david-mcmahon
Copy link
Contributor Author

david-mcmahon commented Nov 13, 2017 •
edited

/test pull-kubernetes-bazel-test

@david-mcmahon
Copy link
Contributor Author

@kubernetes/test-infra-maintainers why is this one not passing?

@mwielgus
Copy link
Contributor

/retest

@enisoc enisoc modified the milestone: v1.7 Nov 20, 2017
@david-mcmahon
Copy link
Contributor Author

/retest

@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
@david-mcmahon
Copy link
Contributor Author

david-mcmahon commented Nov 21, 2017 •
edited

Self-adding missing approved and lgtm based on cherrypick-approved label furnished earlier.

@david-mcmahon david-mcmahon added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2017
@david-mcmahon
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@mtaufen
Copy link
Contributor

mtaufen commented Nov 21, 2017

@david-mcmahon love it

@david-mcmahon
Copy link
Contributor Author

@mtaufen The yelling was a nice unexpected side effect of Ctl-C Ctl-V'ing the rerun command.

@ixdy
Copy link
Member

ixdy commented Nov 22, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 6c609fe into kubernetes:release-1.7 Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy Awaiting requested review from ixdy

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@ixdy ixdy

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet